Skip to content

Conversation

@sgindeed
Copy link

@sgindeed sgindeed commented Oct 7, 2025

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (3eb521b) to head (52c4f7a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6693      +/-   ##
============================================
+ Coverage     75.80%   75.87%   +0.06%     
- Complexity     5804     5828      +24     
============================================
  Files           705      706       +1     
  Lines         19846    19890      +44     
  Branches       3851     3863      +12     
============================================
+ Hits          15045    15091      +46     
+ Misses         4218     4217       -1     
+ Partials        583      582       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan
Copy link
Member

Thank you for your contribution! @sgindeed
However, similar functionality already exists in the following classes:

Your proposed implementation overlaps with these existing ones, so we cannot accept another separate class of the same type.

If you’d like, you can instead improve or refactor the existing classes — for example, by adding clearer documentation, optimizing the logic, or unifying the pattern across “greater” and “smaller” variants.

Thank you again for your effort and understanding! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants