feat(tries): add Patricia (radix) trie with tests #6713
+377
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shimmer12 <[email protected]>
shimmer12
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6713 +/- ##
============================================
+ Coverage 76.43% 77.40% +0.96%
- Complexity 5974 6279 +305
============================================
Files 714 724 +10
Lines 20240 20976 +736
Branches 3927 4094 +167
============================================
+ Hits 15471 16236 +765
+ Misses 4178 4092 -86
- Partials 591 648 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: shimmer12 <[email protected]>
Updated comments for clarity and corrected parameter descriptions in the PatriciaTrie class. Enhanced the remove method to properly handle key removal and cleanup.
Updated remove method to return boolean instead of value. Improved documentation and refactored removeRecursive method.
|
@shimmer12 Please fix the failing workflows so I can start the review. |
|
I tried a lot, I don't know what's going wrong, (haven't committed chanes much to workflows prs) |
|
@shimmer12 Your code isnt formatted correctly and i think your tests are failing |
|
Okay I will modify it, thanks for pointing it out. |
Refactored PatriciaTrie.java for better formatting and clarity.
Updated the test method for inserting into the Patricia Trie to check for size increment when a split occurs. Added assertions to verify the presence of new keys after the split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java