Skip to content

Combination sum fix and test cases #10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 27, 2025
+11 −1
Merged

Combination sum fix and test cases #10193

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b99885
fixed_incorrect_test_combination_sum
architmaheshwari99 Oct 9, 2023
0975b24
reverting fn arg
architmaheshwari99 Oct 9, 2023
ba22496
ruff
architmaheshwari99 Oct 9, 2023
733cec3
Merge branch 'master' into combination_sum_fix_dp
MaximSmolskiy Aug 27, 2025
0c8ec83
Update combination_sum.py
MaximSmolskiy Aug 27, 2025
4302af0
Update combination_sum.py
MaximSmolskiy Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backtracking/combination_sum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,19 @@ def combination_sum(candidates: list, target: int) -> list:
>>> combination_sum([-8, 2.3, 0], 1)
Traceback (most recent call last):
...
RecursionError: maximum recursion depth exceeded
ValueError: All elements in candidates must be non-negative.
>>> combination_sum([], 1)
Traceback (most recent call last):
...
ValueError: Candidates list should not be empty
"""
path = [] # type: list[int]
answer = [] # type: list[int]
if not candidates:
raise ValueError("Candidates list should not be empty")

if any(x < 0 for x in candidates):
raise ValueError("All elements in candidates must be non-negative.")
backtrack(candidates, path, answer, target, 0)
return answer

Expand Down