Skip to content

Conversation

Daanish-Hindustani
Copy link

@Daanish-Hindustani Daanish-Hindustani commented Sep 14, 2024

Describe your change:

As per issue

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Daanish-Hindustani
Copy link
Author

Looks good

Do you know how I can merge to main, since you approved the changes .

@imSanko
Copy link
Contributor

imSanko commented Sep 15, 2024

Looks good

Do you know how I can merge to main, since you approved the changes.

Wait for [at]Claus he'll be reviewing this from his end.

@Daanish-Hindustani
Copy link
Author

Looks good

Do you know how I can merge to main, since you approved the changes.

Wait for [at]Claus he'll be reviewing this from his end.

Do you know when these changes are being reviewed, because its been close to a week or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants