Implementation of DBSCAN algorithm in Machine Learning #11632
Conversation
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/dbscan.py
Outdated
| obj.print_dbscan() | ||
| obj.plot_dbscan() | ||
| ''' | ||
| def __init__(self, minPts : int, radius : int, file : str) -> None: |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minPts
machine_learning/dbscan.py
Outdated
| 7 | 3 | ||
| ----- | ||
| ''' | ||
| self.minPts = minPts |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minPts
machine_learning/dbscan.py
Outdated
| self.radius = radius | ||
| self.file = file | ||
| self.dict1 = self.perform_dbscan() | ||
| def perform_dbscan(self) -> Dict[int, List[int]]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function perform_dbscan
machine_learning/dbscan.py
Outdated
| ''' | ||
| data = pd.read_csv(self.file) | ||
|
|
||
| minPts = self.minPts |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minPts
| dict1[i+1] = [j+1,] | ||
|
|
||
| return dict1 | ||
| def print_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function print_dbscan
| break | ||
| else: | ||
| print("Noise") | ||
| def plot_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function plot_dbscan
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
machine_learning/dbscan.py
Outdated
| import math | ||
| import matplotlib.pyplot as plt | ||
| from typing import dict, list | ||
| class dbScan: |
There was a problem hiding this comment.
Class names should follow the CamelCase naming convention. Please update the following name accordingly: dbScan
machine_learning/dbscan.py
Outdated
| self.radius = radius | ||
| self.file = file | ||
| self.dict1 = self.perform_dbscan() | ||
| def perform_dbscan(self) -> dict[int, list[int]]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function perform_dbscan
| dict1[i+1] = [j+1,] | ||
|
|
||
| return dict1 | ||
| def print_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function print_dbscan
| break | ||
| else: | ||
| print("Noise") | ||
| def plot_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function plot_dbscan
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.radius = radius | ||
| self.file = file | ||
| self.dict1 = self.perform_dbscan() | ||
| def perform_dbscan(self) -> dict[int, list[int]]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function perform_dbscan
| else: | ||
| dict1[i+1] = [j+1,] | ||
| return dict1 | ||
| def print_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function print_dbscan
| break | ||
| else: | ||
| print("Noise") | ||
| def plot_dbscan(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/dbscan.py, please provide doctest for the function plot_dbscan
for more information, see https://pre-commit.ci
1 participant
Describe your change:
Implementation of DBSCAN algorithm from Scratch using Python.
Checklist: