Skip to content

Conversation

FuturistForever
Copy link

@FuturistForever FuturistForever commented Oct 1, 2024

Remove unused function parameter base_pat from the find_prefix_path() function.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2024
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you escalate what are you working with??
Try to solve: 0.30s call matrix/count_negative_numbers_in_sorted_matrix.py::matrix.count_negative_numbers_in_sorted_matrix.generate_large_matrix

@FuturistForever
Copy link
Author

FuturistForever commented Oct 2, 2024

Can you escalate what are you working with??
Try to solve: 0.30s call matrix/count_negative_numbers_in_sorted_matrix.py::matrix.count_negative_numbers_in_sorted_matrix.generate_large_matrix

I'm working with the machine_learning/frequent_pattern_growth.py

In the find_prefix_path() function (Line 243), the base_pat parameter is never used inside the function.

So, I've removed the unused function parameter base_pat from the function definition and the function calls.

The doctest failed because I've not modified the tests for the find_prefix_path() function.

Should I change both code and doctests in a single pull request?

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Oct 2, 2024
@FuturistForever
Copy link
Author

I've updated the tests for the find_prefix_path() function to solve the build issue.

@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 2, 2024
@tianyizheng02 tianyizheng02 merged commit 00e9d86 into TheAlgorithms:master Oct 2, 2024
3 of 4 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts Open a new PR or rebase on the latest commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants