Skip to content

Conversation

RishitPrabhu
Copy link

@RishitPrabhu RishitPrabhu commented Oct 1, 2024

Describe your change:

Issues Eliminated:

  1. Error handling: There's no check for zero pivots in the Gaussian elimination step. If a pivot element is zero, the code will throw a division by zero error. Added a check for this case and swap rows if necessary.
  2. More comments: Added a few more comments for explaining statements
  3. Improve vector manipulation: When indexing the ‘vector’ array, the current code uses ‘[row][0]’, which can be simplified by directly indexing as ‘vector[row]’ for clarity.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Issues Eliminated:

1. Error handling: There's no check for zero pivots in the Gaussian elimination step. If a pivot element is zero, the code will throw a division by zero error. Added a check for this case and swap rows if necessary.
2. More comments: Added a few more comments for explaining statements
3. Improve vector manipulation: When indexing the ‘vector’ array, the current code uses ‘[row][0]’, which can be simplified by directly indexing as ‘vector[row]’ for clarity.
Issues Eliminated:

1. Error handling: There's no check for zero pivots in the Gaussian elimination step. If a pivot element is zero, the code will throw a division by zero error. Added a check for this case and swap rows if necessary.
2. More comments: Added a few more comments for explaining statements
3. Improve vector manipulation: When indexing the ‘vector’ array, the current code uses ‘[row][0]’, which can be simplified by directly indexing as ‘vector[row]’ for clarity.
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant