Skip to content

Conversation

Maanit491
Copy link

Describe your change:

  • Fix a bug or typo in an existing algorithm?

This pull request fixes the Haversine distance calculation in the haversine_distance.py file. The implementation previously used reduced latitudes, which can introduce inaccuracies. This change utilizes raw latitudes directly, ensuring that the calculation aligns with standard practices for spherical distance measurement.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Haversine distance may be using the wrong phi1 and phi2 angle #11308 ".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 1, 2024
@Maanit491 Maanit491 closed this Oct 1, 2024
@Maanit491 Maanit491 reopened this Oct 1, 2024
@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Oct 1, 2024
@Maanit491 Maanit491 closed this Oct 1, 2024
@Maanit491 Maanit491 reopened this Oct 1, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 1, 2024
@Maanit491
Copy link
Author

I have resolved the bug. Please review my PR.

@Maanit491
Copy link
Author

Kindly review my code @cclauss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Haversine distance may be using the wrong phi1 and phi2 angle

2 participants