Skip to content

Update binary_to_decimal.py #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update binary_to_decimal.py #11919

wants to merge 2 commits into from

Conversation

USP-2024
Copy link

@USP-2024 USP-2024 commented Oct 9, 2024 •
edited
Loading

added a python code for BCD to Gray conversion

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

USP-2024 and others added 2 commits October 9, 2024 15:22
@USP-2024
Update binary_to_decimal.py
0e36290 
added a python code for BCD to Gray conversion
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
42dcb08 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2024
saahil-mahato
saahil-mahato reviewed Oct 9, 2024
View reviewed changes
conversions/binary_to_decimal.py
raise ValueError("Input must be a BCD number between 0 and 9.")

# Convert BCD to binary
binary = format(bcd, "04b") # 4-bit binary representation
Copy link
Contributor

@saahil-mahato saahil-mahato Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify the conversion by using bit wise operators like this:
gray = bcd ^ (bcd >> 1)
return format(gray, '04b')

USP-2024
USP-2024 commented Oct 13, 2024
View reviewed changes
Copy link
Author

@USP-2024 USP-2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The can work well by using bit wise operators also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@saahil-mahato saahil-mahato saahil-mahato left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@USP-2024 @saahil-mahato