Paillier Cryptosystem with Homomorphism #12038
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import random | ||
|
|
||
| class Utils: | ||
| def primeGenerator(bit_size): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function primeGenerator
Please provide return type hint for the function: primeGenerator. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: primeGenerator
Please provide type hint for the parameter: bit_size
| high = (2**bit_size) - 1 | ||
| return sympy.randprime(low, high) | ||
|
|
||
| def GCD(a, b): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function GCD
Please provide return type hint for the function: GCD. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: a
Please provide type hint for the parameter: a
Please provide descriptive name for the parameter: b
Please provide type hint for the parameter: b
| a, b = b, a % b | ||
| return a | ||
|
|
||
| def LCM(a, b): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function LCM
Please provide return type hint for the function: LCM. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: a
Please provide type hint for the parameter: a
Please provide descriptive name for the parameter: b
Please provide type hint for the parameter: b
| """ | ||
| return a * b // Utils.GCD(a, b) | ||
|
|
||
| def getInverse(a, n): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function getInverse
Please provide return type hint for the function: getInverse. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getInverse
Please provide descriptive name for the parameter: a
Please provide type hint for the parameter: a
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
| """ | ||
| return pow(a, -1, n) | ||
|
|
||
| def L(x, n): |
There was a problem hiding this comment.
Please provide descriptive name for the function: L
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function L
Please provide return type hint for the function: L. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: n
Please provide type hint for the parameter: n
| """ | ||
| return self.publicKey | ||
|
|
||
| def getPrivateKey(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function getPrivateKey
Please provide return type hint for the function: getPrivateKey. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getPrivateKey
ciphers/paillier_cryptosystem.py
Outdated
| """ | ||
| return self.privateKey | ||
|
|
||
| def encrypt(pubKey : dict, msg : int): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function encrypt
Please provide return type hint for the function: encrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: pubKey
ciphers/paillier_cryptosystem.py
Outdated
| b = pow(r, n, n2) | ||
| return (a*b) % n2 | ||
|
|
||
| def decrypt(prvKey : dict, cypher : int): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function decrypt
Please provide return type hint for the function: decrypt. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: prvKey
ciphers/paillier_cryptosystem.py
Outdated
| msg = (t * mu) % n # (lambda * message) * mu == (lambda * message) * (lambda^-1) == msg (mod n) | ||
| return msg | ||
|
|
||
| def homomorphicADD(pubKey : dict, cypher1 : int, cypher2 : int): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function homomorphicADD
Please provide return type hint for the function: homomorphicADD. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: homomorphicADD
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: pubKey
ciphers/paillier_cryptosystem.py
Outdated
| n2 = pubKey['n2'] | ||
| return (cypher1*cypher2) % n2 | ||
|
|
||
| def homomorphicMUL(pubKey : dict, cypher1 : int, msg2 : int): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/paillier_cryptosystem.py, please provide doctest for the function homomorphicMUL
Please provide return type hint for the function: homomorphicMUL. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: homomorphicMUL
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: pubKey
for more information, see https://pre-commit.ci
|
Closing require_type_hints PRs to prepare for Hacktoberfest |
2 participants
Describe your change:
Checklist: