Skip to content

Conversation

Sinclo
Copy link

@Sinclo Sinclo commented Oct 15, 2024

Describe your change:

Added doctests to game_of_life.py
Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Sinclo
Copy link
Author

Sinclo commented Jan 15, 2025

Hi @cclauss , @tianyizheng02

Sorry to tag as I'm sure you guys are both quite busy. But I wanted to know if it would be possible to kindly review and approve this PR if all looks good (I noticed several other newer PRs have already been reviewed and merged; this one has been open since October 2024). Would love to contribute to your project.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant