Skip to content

Conversation

aarthipv
Copy link

@aarthipv aarthipv commented Dec 3, 2024

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes strings/join.py is incorrect #12408 ".

@osman-haider
Copy link

@aarthipv your code still have same issue

image

if we gave input like this

join(",", ["", "", ""])

then we are expecting output like follows

',,'

But your code still returning empty string

@MaximSmolskiy
Copy link
Member

@aarthipv Point of this repository is to learn how to implement algorithms and built-in functions yourself, so I can't accept implementation of join function using built-in Python join method

Copy link
Member

@MaximSmolskiy MaximSmolskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix my comment above

@algorithms-keeper algorithms-keeper bot added the awaiting changes A maintainer has requested changes to this PR label Dec 29, 2024
@MaximSmolskiy
Copy link
Member

Closed in favor of #12434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes A maintainer has requested changes to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strings/join.py is incorrect
3 participants