Skip to content

Fix split function to handle trailing delimiters correctly #12423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Fix split function to handle trailing delimiters correctly #12423

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e5c669
Fix split function to handle trailing delimiters correctly
kishyassin Dec 6, 2024
393a3c7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 6, 2024
64cbaad
Update split.py
MaximSmolskiy Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions strings/split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ def split(string: str, separator: str = " ") -> list:

>>> split("12:43:39",separator = ":")
['12', '43', '39']

>>> split(";abbb;;c;", separator=';')
['', 'abbb', '', 'c', '']
"""

split_words = []
Expand All @@ -25,6 +28,10 @@ def split(string: str, separator: str = " ") -> list:
last_index = index + 1
elif index + 1 == len(string):
split_words.append(string[last_index : index + 1])

if string and string[-1] == separator:
split_words.append("")

return split_words


Expand Down
Loading