Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions physics/collisions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Basic implementation of the collision of two circles.
def circle_collision(fpos: tuple[float, float, float], spos: tuple[float, float, float]) -> bool:

Check failure on line 2 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

physics/collisions.py:2:89: E501 Line too long (97 > 88)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file physics/collisions.py, please provide doctest for the function circle_collision

# difference by XY axes
dx = fpos[0] - spos[0]
dy = fpos[1] - spos[1]

Check failure on line 6 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (W293)

physics/collisions.py:6:1: W293 Blank line contains whitespace

Check failure on line 7 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (W293)

physics/collisions.py:7:1: W293 Blank line contains whitespace
# Euclidean distance between the centers of circles
distance = pow((pow(dx, 2) + pow(dy, 2)), 0.5)

Check failure on line 10 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (W293)

physics/collisions.py:10:1: W293 Blank line contains whitespace
# minimum possible distance between circles, without collision
min_distance = fpos[2] + fpos[2]

Check failure on line 13 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (W293)

physics/collisions.py:13:1: W293 Blank line contains whitespace
# If actual distance smaller than minimal possible, cirlces collides
if distance < min_distance:
return True

Check failure on line 17 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (W293)

physics/collisions.py:17:1: W293 Blank line contains whitespace
return False

Check failure on line 18 in physics/collisions.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (SIM103)

physics/collisions.py:15:5: SIM103 Return the condition `distance < min_distance` directly
Loading