Skip to content

Update build.yml #12913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Update build.yml #12913

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7450df5
Update build.yml
tanmaykumarchaki Aug 22, 2025
1bcbab1
Update build.yml
tanmaykumarchaki Aug 22, 2025
3ae98df
Update build.yml
tanmaykumarchaki Aug 22, 2025
10e58eb
Update build.yml
tanmaykumarchaki Aug 23, 2025
ff8f54c
Update build.yml
tanmaykumarchaki Aug 23, 2025
263ddaa
Update build.yml
tanmaykumarchaki Aug 23, 2025
bc45977
Merge branch 'master' into patch-1
cclauss Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
name: "build"

on:
pull_request:
schedule:
- cron: "0 0 * * *" # Run everyday

jobs:
build:
name: Build and Test
Expand All @@ -13,7 +11,6 @@ jobs:
- uses: actions/checkout@v5
- name: Checkout Repository
Copy link
Member

@cclauss cclauss Aug 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step only has a name but no run or uses so this GHA is invalid https://github.com/TheAlgorithms/Python/actions/runs/17159313101

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not. https://github.com/TheAlgorithms/Python/pull/12913/checks

- uses: actions/checkout@v4

- uses: astral-sh/setup-uv@v6
- name: Set up uv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astral-sh/setup-uv@v3 tells the reader more than Set up uv does.

- uses: astral-sh/setup-uv@v3
Expand All @@ -27,16 +24,12 @@ jobs:
with:
python-version: 3.11
allow-prereleases: true

- name: Install dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv sync --group=test tells the reader more than Install dependencies.

- run: |
uv sync --all-extras
uv pip list

- name: Lint code
run: uv run ruff check , --output-format=github


run: uv run ruff check , --output-format=github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the comma (,) do on this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it .

Copy link
Member

@cclauss cclauss Aug 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the . useful? If not, let's remove it.

- name: Run tests
# TODO: #8818 Re-enable quantum tests
run: uv run pytest
Expand All @@ -52,10 +45,8 @@ jobs:
--ignore=web_programming/fetch_anime_and_play.py
--cov-report=term-missing:skip-covered
--cov=. .

- name: Build package (if needed)
run: uv build

- if: ${{ success() }}
run: scripts/build_directory_md.py 2>&1 | tee DIRECTORY.md