-
-
Notifications
You must be signed in to change notification settings - Fork 342
feat: added string rotation #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0881074
added string rotation
Arpita23r c3af8d4
Merge branch 'master' into feat/str-rot-arpi23r
Arpita23r ebc9ed2
Merge branch 'master' into feat/str-rot-arpi23r
Arpita23r c916c61
Merge branch 'master' into feat/str-rot-arpi23r
Arpita23r a5ee090
Merge branch 'master' into feat/str-rot-arpi23r
siriak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # String Rotation Check in R | ||
| # Checks if one string is a rotation of another string. | ||
|
|
||
| is_rotation <- function(s1, s2) { | ||
| # Check length first | ||
| if (nchar(s1) != nchar(s2)) { | ||
| return(FALSE) | ||
| } | ||
|
|
||
| # Concatenate s1 with itself and check if s2 is a substring | ||
| combined <- paste0(s1, s1) | ||
| return(grepl(s2, combined, fixed = TRUE)) | ||
| } | ||
siriak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Interactive input | ||
| s1 <- tolower(readline("Enter first string: ")) | ||
| s2 <- tolower(readline("Enter second string: ")) | ||
siriak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (is_rotation(s1, s2)) { | ||
| cat("Yes, '", s2, "' is a rotation of '", s1, "'.\n", sep = "") | ||
| } else { | ||
| cat("No, '", s2, "' is not a rotation of '", s1, "'.\n", sep = "") | ||
| } | ||
|
Comment on lines
+16
to
+23
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function doesn't handle empty strings correctly. When both strings are empty,
nchar()returns 0 for both, they pass the length check, andgrepl('', '', fixed = TRUE)returns TRUE, which is incorrect since empty strings should not be considered rotations of each other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the result? You haven't changed anything and haven't responded to the comment