Skip to content

Conversation

@Ismael144
Copy link

@Ismael144 Ismael144 commented Oct 10, 2024

Pull Request Template

Description

A Queue implementation using a singly linked list, its fast and efficient because of the linked list

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 85.52189% with 43 lines in your changes missing coverage. Please review.

Project coverage is 95.24%. Comparing base (0dbaff5) to head (7de3d7f).

Files with missing lines Patch % Lines
.../data_structures/queue_using_singly_linked_list.rs 85.52% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   95.36%   95.24%   -0.13%     
==========================================
  Files         311      312       +1     
  Lines       22673    22970     +297     
==========================================
+ Hits        21623    21877     +254     
- Misses       1050     1093      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02
Copy link
Member

vil02 commented Oct 10, 2024

If I see correctly this is already implemented in queue.rs.

@vil02
Copy link
Member

vil02 commented Oct 12, 2024

Closed as duplicate.

@vil02 vil02 closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants