Skip to content

Fix bounds on delete_ith #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Fix bounds on delete_ith #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/data_structures/linked_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,15 @@ impl<T> LinkedList<T> {
}

pub fn delete_ith(&mut self, index: u32) -> Option<T> {
if self.length < index {
if self.length <= index {
panic!("Index out of bounds");
}

if index == 0 || self.head.is_none() {
return self.delete_head();
}

if self.length == index {
if self.length - 1 == index {
return self.delete_tail();
}

Expand Down Expand Up @@ -499,4 +499,14 @@ mod tests {
assert!(retrived_item.is_some());
assert_eq!("B", *retrived_item.unwrap());
}

#[test]
#[should_panic(expected = "Index out of bounds")]
fn delete_ith_panics_if_index_equals_length() {
let mut list = LinkedList::<i32>::new();
list.insert_at_tail(1);
list.insert_at_tail(2);
// length is 2, so index 2 is out of bounds
list.delete_ith(2);
}
}