Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/data_structures/rb_tree.rs
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,12 @@ unsafe fn delete_fixup<K: Ord, V>(tree: &mut RBTree<K, V>, mut parent: *mut RBNo
let mut sr: *mut RBNode<K, V>;

loop {
// rb-tree will keep color balance up to root,
// if parent is null, we are done.
if parent.is_null() {
break;
}

/*
* Loop invariants:
* - node is black (or null on first iteration)
Expand Down Expand Up @@ -647,4 +653,23 @@ mod tests {
let s: String = tree.iter().map(|x| x.value).collect();
assert_eq!(s, "hlo orl!");
}

#[test]
fn delete_edge_case_null_pointer_guard() {
let mut tree = RBTree::<i8, i8>::new();
tree.insert(4, 4);
tree.insert(2, 2);
tree.insert(5, 5);
tree.insert(0, 0);
tree.insert(3, 3);
tree.insert(-1, -1);
tree.insert(1, 1);
tree.insert(-2, -2);
tree.insert(6, 6);
tree.insert(7, 7);
tree.insert(8, 8);
tree.delete(&1);
tree.delete(&3);
tree.delete(&-1);
}
}