change + and - icons

[iTrooz]

Hey, I've noticed the + icon doesn't appear in my environment (ArchLinux KDE), and that the - icon appear for some reason even if Qt Creator doesn't mention it in the icons list

I've replaced them with elements that were in the list of icons

I tested the changes in ZorinOS 18.04 (running an Gnome environment IIRC) and Debian 11 running XFCE and the modified icons appear in both of them (plus in my own environment ofc)

[TheAssassin]

Thanks. Let's target the upcoming release. Will hopefully be merged at a later point.

[TheAssassin]

Please rebase so that we can test this.

[iTrooz]

Btw, here is the proof "add" and "remove" aren't standard: https://specifications.freedesktop.org/icon-naming-spec/latest/

[TheAssassin]

Could you provide a screenshot of the new icons on your theme?

[iTrooz]

Unfortunately this will take some time as I'm getting C++ compilation errors with zsync2

/home/itrooz/moi/workspaces/others/AppImageLauncher/build/_deps/zsync2-src/lib/libzsync/zsync.c: In function ‘zsync_get_urls’:
/home/itrooz/moi/workspaces/others/AppImageLauncher/build/_deps/zsync2-src/lib/libzsync/zsync.c:460:18: error: returning ‘char **’ from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  460 |         return zs->zurl;
      |                ~~^~~~~~
/home/itrooz/moi/workspaces/others/AppImageLauncher/build/_deps/zsync2-src/lib/libzsync/zsync.c:465:18: error: returning ‘char **’ from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  465 |         return zs->url;
      |                ~~^~~~~

[iTrooz]

Actually, the component that fails is something else, the settings binary still compiled.

So here it is without the patch:

And with the patch:

[TheAssassin]

Seems to work. Have you made your edits with Qt Creator/Qt Designer? I wonder where the second line is coming from.

[TheAssassin]

Looks like it's correct the way it is now. Merging. Thanks @iTrooz!