bevy run web: only compile default_run target when no binary is specified#237
Merged
TimJentzsch merged 1 commit intoTheBevyFlock:mainfrom Jan 22, 2025
Merged
Conversation
TimJentzsch
approved these changes
Jan 22, 2025
Collaborator
TimJentzsch
left a comment
There was a problem hiding this comment.
I first though this might not work if you have two different packages which contain a binary with the same name.
But it turns out Cargo doesn't allow that in workspaces, at least it prints out a warning in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Closes #200.
Improve compile time by only compiling the default run target if available and no specific binary is omitted via the
--binor--exampleflags.Solution
Check if
bevy runwas called with either--binor--example. If not search for the default_run binary name and append it with--binbefore callingbuild_web(&mut build_args)Testing
Before:
Now: