-
Notifications
You must be signed in to change notification settings - Fork 32
Release linter v0.5.0 #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - `iter_current_update_events` lint got renamed to `iter_current_update_messages`. | ||
| - Bumped nightly toolchain to `nightly-2025-12-11` ([#697](https://github.com/TheBevyFlock/bevy_cli/pull/697)) | ||
|
|
||
| ### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move this section to be above the "Changed" section, so that it is consistent with previous changelogs?
|
|
||
| ### Removed | ||
|
|
||
| - Deprecated lint `insert_unit_bundle` was removed ([#724](https://github.com/TheBevyFlock/bevy_cli/pull/724)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Deprecated lint `insert_unit_bundle` was removed ([#724](https://github.com/TheBevyFlock/bevy_cli/pull/724)) | |
| - Deprecated lint `insert_unit_bundle` was removed ([#724](https://github.com/TheBevyFlock/bevy_cli/pull/724)) | |
| - Please use the `unit_in_bundle` lint instead. |
I want to make it clear that the functionality behind insert_unit_bundle isn't going away, just the name :)
| - The Bevy CLI (Alpha) can now lint web Bevy apps ([#523](https://github.com/TheBevyFlock/bevy_cli/pull/523)) | ||
| - The Bevy CLI (Alpha) can now install any `bevy_lint` version ([#529](https://github.com/TheBevyFlock/bevy_cli/pull/529)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two changes were strictly made to the CLI, not the linter, so I'm hesitant to include them in the linter's changelog. What do you think? Maybe we can mention it in the release announcement, rather than here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea im fine with taking them out. I saw that you mentioned the installation feature in the past version iirc, so I included it here
| [Semantic Versioning]: https://semver.org/spec/v2.0.0.html | ||
|
|
||
| ## Unreleased | ||
| ## v0.5.0 - TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note so we don't forget to update the date (this has happened too much in the past 😅)
| [the releases page]: https://github.com/TheBevyFlock/bevy_cli/releases | ||
| [submit an issue]: https://github.com/TheBevyFlock/bevy_cli/issues | ||
|
|
||
| ## v0.4.0 to v0.5.0 (Unreleased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to comment on it directly, but below this comment is the header:
## Renaming the lints that targeted "buffered" EventsThis should be a level 3 heading, using ### rather than ##.
It has been around 167 Days since the last release 😲
While there are not that many new features, this mainly serves to provide a release that is compatible with bevy 0.17.0 (So we can update to bevy 0.18.0 for the jam).
Useful Links
mdbook serveto view the updated, rendered version locally!)For Reviewers
Please try the linter with all your projects. Just so you know, the linter does not yet support bevy 0.18.0, so you may have to switch to an older version of your test project.
Install with
bevy lint install mainWhile testing, make sure to test the lints that are disabled by default (
pedantic,restriction,nursery). You can enable these lints throughCargo.tomlor directly in your code.Next steps
Once this PR has received at least 1 approval from a Bevy maintainer with no outstanding requests, it will be merged. No other PRs will be merged until a Github Release is made and the post-release PR is merged.
After the Release I plan to poke @BD103 for a Review so we can get #703 merged. Additionally, annoying Cart from time to time again, so he does not forget our upstreaming proposal ^^