Update Cargo.toml

[zeddash]

Making it clear the second part is to be used in conjunction with the first. I didn't know the syntax and thought it was A or B, not A or (A and B).

I got really confused and just an extra word "additional" would have cleared things up and I'd have known I need both.

I read the "Alternatively" as "that one has a rustflag check, this one doesn't"

[benfrankel]

I read the "Alternatively" as "that one has a rustflag check, this one doesn't"

This is correct. The patch only removes the rustflags check and nothing else.

Basically it's "feature and rustflags" or "feature and patch".

[zeddash]

Wouldn't that then mean you just need the second and not both? It only started to work when I enabled both

[target.wasm32-unknown-unknown.dependencies]
getrandom = { version = "0.3", features = ["wasm_js"] }

and

[patch.crates-io]
getrandom = { git = "https://github.com/benfrankel/getrandom" }

But I was reading it that I could just use the patch

[benfrankel]

Yes, in either case you have to add getrandom as an explicit dependency in order to specify the wasm_js feature on it. "Alternatively" only relates to the rustflags section. Maybe it would be more clear with a newline between the two sections.

[zeddash]

I think just adding my tiny change of specifying the second part is additional is enough, just clearly states it’s, well, additional

…

________________________________ From: Ben Frankel ***@***.***> Sent: Saturday, August 2, 2025 2:36:32 AM To: TheBevyFlock/bevy_new_2d ***@***.***> Cc: z- ***@***.***>; Author ***@***.***> Subject: Re: [TheBevyFlock/bevy_new_2d] Update Cargo.toml (PR #449) [https://avatars.githubusercontent.com/u/12173779?s=20&v=4]benfrankel left a comment (TheBevyFlock/bevy_new_2d#449)<#449 (comment)> Yes, in either case you have to add getrandom as an explicit dependency in order to specify the wasm_js feature on it. "Alternatively" only relates to the rustflags section. Maybe it would help to put a newline between the two sections. — Reply to this email directly, view it on GitHub<#449 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALGMQGNZFAHIP4WQVZ7BD733LQI2BAVCNFSM6AAAAACC4OLITWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBWGEYDAOJXGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>