Refactor View Models

Author: TheCodeTraveler

sample/ViewModels/NewsViewModel_BadAsyncAwaitPractices.cs

@@ -75,7 +75,7 @@ async Task<FrozenSet<StoryModel>> GetTopStories(CancellationToken token, int sto
 				break;
 		}
 
-		return topStoryList.Where(x => x is not null).OrderByDescending(x => x.Score).ToFrozenSet();
+		return topStoryList.OrderByDescending(x => x.Score).ToFrozenSet();
 	}
 
 	//ToDo Refactor

sample/ViewModels/NewsViewModel_GoodAsyncAwaitPractices.cs

@@ -4,19 +4,13 @@
 
 namespace HackerNews;
 
-partial class NewsViewModel : BaseViewModel
+partial class NewsViewModel(IDispatcher dispatcher, HackerNewsAPIService hackerNewsAPIService) : BaseViewModel(dispatcher)
 {
-	readonly HackerNewsAPIService _hackerNewsAPIService;
 	readonly WeakEventManager _pullToRefreshEventManager = new();
 
 	[ObservableProperty]
 	bool _isListRefreshing;
 
-	public NewsViewModel(IDispatcher dispatcher, HackerNewsAPIService hackerNewsAPIService) : base(dispatcher)
-	{
-		_hackerNewsAPIService = hackerNewsAPIService;
-	}
-
 	public event EventHandler<string> PullToRefreshFailed
 	{
 		add => _pullToRefreshEventManager.AddEventHandler(value);
@@ -51,9 +45,9 @@ async Task Refresh(CancellationToken token)
 
 	async IAsyncEnumerable<StoryModel> GetTopStories(int storyCount, [EnumeratorCancellation] CancellationToken token)
 	{
-		var topStoryIds = await _hackerNewsAPIService.GetTopStoryIDs(token).ConfigureAwait(false);
+		var topStoryIds = await hackerNewsAPIService.GetTopStoryIDs(token).ConfigureAwait(false);
 
-		var getTopStoryTaskList = topStoryIds.Select(id => _hackerNewsAPIService.GetStory(id, token)).ToList();
+		var getTopStoryTaskList = topStoryIds.Select(id => hackerNewsAPIService.GetStory(id, token)).ToList();
 
 		while (getTopStoryTaskList.Any() && storyCount-- > 0)
 		{