Skip to content

Commit 9e09026

Browse files
author
TheCodingSheikh
committed
feat: update kubeflow chart
1 parent 4d31e68 commit 9e09026

File tree

5 files changed

+80
-34
lines changed

5 files changed

+80
-34
lines changed

charts/kubeflow/Chart.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ description: >
55
preconfigured according to the upstream examples/kustomization.yaml structure.
66
77
type: application
8-
version: 1.0.1
8+
version: 1.0.2
99
appVersion: "1.10.0"
1010

1111
home: https://github.com/TheCodingSheikh/helm-charts/tree/main/charts/kubeflow
@@ -19,8 +19,3 @@ keywords:
1919
- helm
2020
- gitops
2121
- machine-learning
22-
23-
dependencies:
24-
- name: raw
25-
version: 1.0.1
26-
repository: https://thecodingsheikh.github.io/helm-charts

charts/kubeflow/README.md

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,18 @@ kubeflowManifestsRepo: https://github.com/kubeflow/manifests
4141
# Git branch to use
4242
kubeflowManifestsRepoBranch: HEAD
4343

44+
# Argo app specs
45+
defaultAppSpec: {}
46+
4447
# All resources you want to deploy
4548
resources:
46-
<componentName>: < this will be the argo app name converted to [kebabcase](https://helm.sh/docs/chart_template_guide/function_list/#kebabcase)
49+
<componentName>: < this will be the argo app name converted to [kebabcase](https://helm.sh/docs/chart_template_guide/function_list/#kebabcase) and prepended by "kubeflow-"
4750
enabled: true | false (required)
4851
path: <path/in/repo> (required)
4952
appNameOverride: custom argo app name (optional)
5053
repoOverride: custom repo source (optional - defaults to `kubeflowManifestsRepo`)
5154
repoBranchOverride: custom repo branch (optional - defaults to `kubeflowManifestsRepoBranch`)
55+
appSpecOverride: custom argo app specs (optional - defaults to `defaultAppSpec`)
5256
labels: argo app labels (optional)
5357
annotations: argo app annotations (optional)
5458
kustomize: [kustomize config for argo app](https://argo-cd.readthedocs.io/en/latest/user-guide/kustomize/#patches) (optional)
@@ -69,6 +73,27 @@ argoNamespace: argocd
6973
destinationServer: https://kubernetes.default.svc
7074
kubeflowManifestsRepo: https://github.com/kubeflow/manifests
7175
kubeflowManifestsRepoBranch: HEAD
76+
defaultAppSpec:
77+
ignoreDifferences:
78+
- group: argoproj.io
79+
jsonPointers:
80+
- /status
81+
kind: Application
82+
syncPolicy:
83+
automated:
84+
allowEmpty: true
85+
prune: true
86+
selfHeal: true
87+
retry:
88+
backoff:
89+
duration: 20s
90+
factor: 3
91+
maxDuration: 20s
92+
limit: 30
93+
syncOptions:
94+
- ApplyOutOfSyncOnly=true
95+
- ServerSideApply=true
96+
- CreateNamespace=true
7297
7398
resources:
7499
certManagerBase:
@@ -107,19 +132,19 @@ resources:
107132
enabled: true
108133
path: common/istio-1-24/cluster-local-gateway/base
109134
110-
kubeflowNamespace:
135+
namespace:
111136
enabled: true
112137
path: common/kubeflow-namespace/base
113138
114139
networkPolicies:
115140
enabled: true
116141
path: common/networkpolicies/base
117142
118-
kubeflowRoles:
143+
roles:
119144
enabled: true
120145
path: common/kubeflow-roles/base
121146
122-
kubeflowIstioResources:
147+
istioResources:
123148
enabled: true
124149
path: common/istio-1-24/kubeflow-istio-resources/base
125150

charts/kubeflow/templates/application.yaml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
apiVersion: argoproj.io/v1alpha1
77
kind: Application
88
metadata:
9-
name: {{ default $config.appNameOverride (kebabcase $app) }}
9+
name: kubeflow-{{ default $config.appNameOverride (kebabcase $app) }}
1010
namespace: {{ $root.Values.argoNamespace }}
1111
{{- if $config.labels }}
1212
labels:
@@ -30,25 +30,7 @@ spec:
3030
destination:
3131
server: {{ $root.Values.destinationServer }}
3232
namespace: {{ $root.Values.argoNamespace }}
33-
ignoreDifferences:
34-
- group: argoproj.io
35-
jsonPointers:
36-
- /status
37-
kind: Application
38-
syncPolicy:
39-
automated:
40-
allowEmpty: true
41-
prune: true
42-
selfHeal: true
43-
retry:
44-
backoff:
45-
duration: 1m
46-
factor: 2
47-
maxDuration: 16m
48-
limit: 10
49-
syncOptions:
50-
- ApplyOutOfSyncOnly=true
51-
- ServerSideApply=true
33+
{{ toYaml (default $root.Values.defaultAppSpec $config.appSpecOverride) | indent 2 }}
5234
{{- end }}
5335
{{- end }}
5436
{{- end }}

charts/kubeflow/templates/raw.yaml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
apiVersion: argoproj.io/v1alpha1
2+
kind: Application
3+
metadata:
4+
name: kubeflow-raw
5+
namespace: {{ .Values.argoNamespace }}
6+
{{- $annotations := .Values.commonAppAnnotations }}
7+
{{- if $annotations }}
8+
annotations:
9+
{{ toYaml $annotations | indent 4 }}
10+
{{- end }}
11+
spec:
12+
project: {{ .Values.argoProjectName }}
13+
source:
14+
repoURL: https://thecodingsheikh.github.io/helm-charts
15+
targetRevision: 1.0.1
16+
chart: raw
17+
helm:
18+
values: |
19+
{{ toYaml .Values.raw | indent 8 }}
20+
destination:
21+
server: {{ .Values.destinationServer }}
22+
namespace: {{ .Values.argoNamespace }}
23+
{{ toYaml .Values.defaultAppSpec | indent 2 }}

charts/kubeflow/values.yaml

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,27 @@ commonAppAnnotations: {}
44
destinationServer: https://kubernetes.default.svc
55
kubeflowManifestsRepo: https://github.com/kubeflow/manifests
66
kubeflowManifestsRepoBranch: HEAD
7+
defaultAppSpec:
8+
ignoreDifferences:
9+
- group: argoproj.io
10+
jsonPointers:
11+
- /status
12+
kind: Application
13+
syncPolicy:
14+
automated:
15+
allowEmpty: true
16+
prune: true
17+
selfHeal: true
18+
retry:
19+
backoff:
20+
duration: 20s
21+
factor: 3
22+
maxDuration: 20s
23+
limit: 30
24+
syncOptions:
25+
- ApplyOutOfSyncOnly=true
26+
- ServerSideApply=true
27+
- CreateNamespace=true
728

829
resources:
930
certManagerBase:
@@ -42,19 +63,19 @@ resources:
4263
enabled: true
4364
path: common/istio-1-24/cluster-local-gateway/base
4465

45-
kubeflowNamespace:
66+
namespace:
4667
enabled: true
4768
path: common/kubeflow-namespace/base
4869

4970
networkPolicies:
5071
enabled: true
5172
path: common/networkpolicies/base
5273

53-
kubeflowRoles:
74+
roles:
5475
enabled: true
5576
path: common/kubeflow-roles/base
5677

57-
kubeflowIstioResources:
78+
istioResources:
5879
enabled: true
5980
path: common/istio-1-24/kubeflow-istio-resources/base
6081

@@ -119,4 +140,4 @@ resources:
119140
path: apps/kserve/models-web-app/overlays/kubeflow
120141

121142
raw:
122-
resources: {}
143+
resources: {}

0 commit comments

Comments
 (0)