This repository was archived by the owner on Sep 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
feat(FluidGrid): implement material-ui inspired grid #114
Draft
betaboon
wants to merge
5
commits into
TheComputerM:master
Choose a base branch
from
betaboon:feature/fluidgrid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba3a2cd
feat(flex): add justify-space-evenly
betaboon 2a405ce
docs(Playground): add ability to define additional options for Slider
betaboon 9d31eb0
feat(FluidGrid): implement material-ui inspired grid
betaboon 4e7190b
refactor(FluidGrid): get rid of global style
betaboon 0a08ff4
fix(FluidGrid): re-add klass (for now)
betaboon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,216 @@ | ||
| { | ||
| "version": 3, | ||
| "name": "FluidGrid", | ||
| "data": [ | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "container", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "boolean", | ||
| "type": "boolean" | ||
| }, | ||
| "defaultValue": false | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "item", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "boolean", | ||
| "type": "boolean" | ||
| }, | ||
| "defaultValue": false | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "spacing", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "direction", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "justify", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "alignItems", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "xs", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "sm", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "md", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "lg", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "xl", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "style", | ||
| "kind": "let", | ||
| "static": false, | ||
| "readonly": false, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "object", | ||
| "type": "object" | ||
| }, | ||
| "defaultValue": null | ||
| }, | ||
| { | ||
| "visibility": "public", | ||
| "description": null, | ||
| "keywords": [], | ||
| "name": "class", | ||
| "kind": "const", | ||
| "static": false, | ||
| "readonly": true, | ||
| "type": { | ||
| "kind": "type", | ||
| "text": "string", | ||
| "type": "string" | ||
| }, | ||
| "localName": "klass" | ||
| } | ||
| ], | ||
| "computed": [], | ||
| "methods": [], | ||
| "components": [], | ||
| "description": null, | ||
| "keywords": [], | ||
| "events": [], | ||
| "slots": [ | ||
| { | ||
| "name": "default", | ||
| "description": null, | ||
| "visibility": "public", | ||
| "parameters": [] | ||
| } | ||
| ], | ||
| "refs": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
| "Divider", | ||
| "ExpansionPanel", | ||
| "ExpansionPanels", | ||
| "FluidGrid", | ||
| "Footer", | ||
| "Col", | ||
| "Container", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <script> | ||
| import { FluidGrid } from 'svelte-materialify/src'; | ||
| </script> | ||
|
|
||
| <FluidGrid container spacing={3}> | ||
| <FluidGrid item xs> | ||
| <div>xs</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs> | ||
| <div>xs</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs> | ||
| <div>xs</div> | ||
| </FluidGrid> | ||
| </FluidGrid> | ||
|
|
||
| <FluidGrid container spacing={3}> | ||
| <FluidGrid item xs> | ||
| <div>xs</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6}> | ||
| <div>xs=6</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs> | ||
| <div>xs</div> | ||
| </FluidGrid> | ||
| </FluidGrid> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <script> | ||
| import { FluidGrid } from 'svelte-materialify/src'; | ||
| </script> | ||
|
|
||
| <FluidGrid container spacing={3}> | ||
| <FluidGrid item xs={12}> | ||
| <div>xs=12</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6}> | ||
| <div>xs=6</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6}> | ||
| <div>xs=6</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={3}> | ||
| <div>xs=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={3}> | ||
| <div>xs=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={3}> | ||
| <div>xs=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={3}> | ||
| <div>xs=3</div> | ||
| </FluidGrid> | ||
| </FluidGrid> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <script> | ||
| import { FluidGrid } from 'svelte-materialify/src'; | ||
| </script> | ||
|
|
||
| <FluidGrid container spacing={3}> | ||
| <FluidGrid item xs={12}> | ||
| <div>xs=12</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={12} sm={6}> | ||
| <div>xs=12 sm=6</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={12} sm={6}> | ||
| <div>xs=12 sm=6</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6} sm={3}> | ||
| <div>xs=6 sm=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6} sm={3}> | ||
| <div>xs=6 sm=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6} sm={3}> | ||
| <div>xs=6 sm=3</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={6} sm={3}> | ||
| <div>xs=6 sm=3</div> | ||
| </FluidGrid> | ||
| </FluidGrid> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <script> | ||
| import { FluidGrid } from 'svelte-materialify/src'; | ||
| </script> | ||
|
|
||
| <FluidGrid container spacing={1}> | ||
| {#each Array(3) as _} | ||
| <FluidGrid container item xs={12} spacing={3}> | ||
| <FluidGrid item xs={4}> | ||
| <div>xs=4</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={4}> | ||
| <div>xs=4</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs={4}> | ||
| <div>xs=4</div> | ||
| </FluidGrid> | ||
| </FluidGrid> | ||
| {/each} | ||
| </FluidGrid> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <script> | ||
| import { FluidGrid } from 'svelte-materialify/src'; | ||
| </script> | ||
|
|
||
| <FluidGrid container> | ||
| <FluidGrid item xs> | ||
| <div>One of Three</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs> | ||
| <div>One of Three</div> | ||
| </FluidGrid> | ||
| <FluidGrid item xs> | ||
| <div>One of Three</div> | ||
| </FluidGrid> | ||
| </FluidGrid> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these newly added settings duplicate the defaults of
Sliderwhich feels wrong as they might diverge.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for now, or what would you do instead? 😄