Skip to content

Constants DAY, MONTH and WEEK was deleted from Ttl class #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrey-helldar merged 1 commit into from
Feb 20, 2025
Merged

Constants DAY, MONTH and WEEK was deleted from Ttl class #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,6 @@ Cache::make()->ttl(fn () => 10);

Cache::make()->ttl(Carbon::now()->addDay());
Cache::make()->ttl(new DateTime('tomorrow'));

Cache::make()->ttl(Ttl::DAY);
Cache::make()->ttl(Ttl::WEEK);
Cache::make()->ttl(Ttl::MONTH);
```

##### As Seconds
Expand Down
6 changes: 6 additions & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,9 @@ This means that the `DragonCode\Contracts\*` contracts will no longer be working
### Replaces Namespaces

- `DragonCode\Contracts\Support\Arrayable` replace with `Illuminate\Contracts\Support\Arrayable`

## Low Impact Changes

### TTL Time Constants

Constants `DAY`, `MONTH` and `WEEK` was deleted from `DragonCode\Cache\Support\Ttl` class.
6 changes: 0 additions & 6 deletions src/Support/Ttl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ class Ttl
use Call;
use Has;

/** @deprecated */
public const DAY = 60 * 24;

public const MONTH = 60 * 24 * 30;
public const WEEK = 60 * 24 * 7;

protected int $default = 3600;

public function fromMinutes($minutes): int
Expand Down
Loading