Skip to content

#428 - Update OutputObservableRequired type#429

Closed
3lina wants to merge 3 commits intoTheHive-Project:mainfrom
3lina:428-update-outputobservable-type
Closed

#428 - Update OutputObservableRequired type#429
3lina wants to merge 3 commits intoTheHive-Project:mainfrom
3lina:428-update-outputobservable-type

Conversation

@3lina
Copy link
Contributor

@3lina 3lina commented May 16, 2025

Update OutputObservableRequired type with the tlpLabel and papLabel as both attributes are stated as required here https://docs.strangebee.com/thehive/api-docs/#tag/Observable/operation/Get%20Observable.

@3lina 3lina force-pushed the 428-update-outputobservable-type branch 2 times, most recently from 0fe6d91 to 8b421ff Compare May 16, 2025 07:15
@Kamforka Kamforka self-requested a review May 16, 2025 07:16
@Kamforka Kamforka added 2.x changelog:added changelog label for new features. changelog:changed changelog label for changes in existing functionality and removed changelog:added changelog label for new features. labels May 16, 2025
@Kamforka Kamforka added this to the 2.0.0b11 milestone May 16, 2025
@Kamforka
Copy link
Collaborator

The repository policy requires the commits to be signed, can you please follow this guide to comply: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits ?

Once you added your GPG key you must rebase and push again.

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (59b08a5) to head (8b421ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          28       28           
  Lines         783      783           
=======================================
  Hits          732      732           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3lina 3lina force-pushed the 428-update-outputobservable-type branch from 8b421ff to 00f2ee2 Compare May 16, 2025 07:53
@3lina 3lina closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x changelog:changed changelog label for changes in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants