#428 - Update OutputObservableRequired type#429
Closed
3lina wants to merge 3 commits intoTheHive-Project:mainfrom
Closed
#428 - Update OutputObservableRequired type#4293lina wants to merge 3 commits intoTheHive-Project:mainfrom
3lina wants to merge 3 commits intoTheHive-Project:mainfrom
Conversation
0fe6d91 to
8b421ff
Compare
Collaborator
|
The repository policy requires the commits to be signed, can you please follow this guide to comply: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits ? Once you added your GPG key you must rebase and push again. |
Kamforka
approved these changes
May 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 28 28
Lines 783 783
=======================================
Hits 732 732
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8b421ff to
00f2ee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OutputObservableRequired type with the tlpLabel and papLabel as both attributes are stated as required here https://docs.strangebee.com/thehive/api-docs/#tag/Observable/operation/Get%20Observable.