Skip to content

#428 - Update OutputObservableRequired type#430

Merged
Kamforka merged 1 commit intoTheHive-Project:mainfrom
3lina:428-update-outputobservablerequired-type
May 16, 2025
Merged

#428 - Update OutputObservableRequired type#430
Kamforka merged 1 commit intoTheHive-Project:mainfrom
3lina:428-update-outputobservablerequired-type

Conversation

@3lina
Copy link
Contributor

@3lina 3lina commented May 16, 2025

Update OutputObservableRequired type with the tlpLabel and papLabel as both attributes are stated as required here https://docs.strangebee.com/thehive/api-docs/#tag/Observable/operation/Get%20Observable.

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (59b08a5) to head (f56c454).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          28       28           
  Lines         783      783           
=======================================
  Hits          732      732           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kamforka Kamforka linked an issue May 16, 2025 that may be closed by this pull request
@Kamforka Kamforka self-requested a review May 16, 2025 10:54
@Kamforka Kamforka added 2.x changelog:changed changelog label for changes in existing functionality labels May 16, 2025
@Kamforka Kamforka added this to the 2.0.0b11 milestone May 16, 2025
@Kamforka Kamforka merged commit 5835075 into TheHive-Project:main May 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x changelog:changed changelog label for changes in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OutputObservable type with missing attributes

2 participants