Better Japanese post-processing #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

TheJoeFin wants to merge 6 commits into main from better-cjk

+327 −8

Draft

Better Japanese post-processing #570

Refactor OCR logic and remove unused namespace

Annotations

28 warnings

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Tests/StringMethodTests.cs#L432

The field 'StringMethodTests.actualGuids' is assigned but its value is never used

Tests/ExtractedPatternTests.cs#L574

Cannot convert null literal to non-nullable reference type.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Text-Grab/Views/EditTextWindow.xaml.cs#L1724

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Views/EditTextWindow.xaml.cs#L1710

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Text-Grab/Utilities/OcrUtilities.cs#L231

Possible null reference argument for parameter 'recognizedText' in 'WinAiOcrLinesWords.WinAiOcrLinesWords(RecognizedText recognizedText)'.

Text-Grab/Views/GrabFrame.xaml.cs#L969

Possible null reference argument for parameter 'language' in 'Task<(IOcrLinesWords?, double)> OcrUtilities.GetOcrResultFromRegionAsync(Rectangle region, ILanguage language)'.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Better Japanese post-processing #570

Uh oh!

Better Japanese post-processing #570

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...

Uh oh!

Better Japanese post-processing #570

Are you sure you want to change the base?

Refactor OCR logic and remove unused namespace

Uh oh!

Better Japanese post-processing #570

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...