Skip to content

Refactor post-grab actions: fix memory leaks, improve performance, enhance maintainability #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheJoeFin merged 5 commits into from
Jan 11, 2026
Merged

Refactor post-grab actions: fix memory leaks, improve performance, enhance maintainability #607

TheJoeFin merged 5 commits into from
Jan 11, 2026
+71 −26

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026 •
edited
Loading

  • Fix ButtonInfo.GetHashCode to include DefaultCheckState property
  • Refactor TrimEachLine_Click to use LINQ instead of string concatenation in loop
  • Move PreviewKeyDown event handler outside the loop in LoadDynamicPostGrabActions
  • Add cleanup for dynamically created menu items in Window_Unloaded
  • Use explicit .Where() filtering in PostGrabActionManager.cs (2 locations)
  • Combine nested if statements in PostGrabActionManager.GetCheckState
  • Combine nested if statements in FullscreenGrab.PostActionMenuItem_Click
  • Fix TrimEachLine to preserve original behavior
  • Use Tag property for menu item identification instead of string comparison
  • Remove unused System.Text import
  • Define constants for menu item tags to avoid duplication
  • Use explicit types (IEnumerable and string[]) instead of var
  • Run code review and security scan - no issues found

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 11, 2026
Open
Copilot AI changed the title [WIP] Add customizable post grab actions feature Refactor post-grab actions: fix memory leaks, improve performance, enhance maintainability Jan 11, 2026
Copilot AI requested a review from TheJoeFin January 11, 2026 20:46
TheJoeFin
TheJoeFin requested changes Jan 11, 2026
View reviewed changes
Text-Grab/Utilities/PostGrabActionManager.cs Outdated
allPostGrabActions.Add(button);
}
}
var relevantActions = ButtonInfo.AllButtons
Copy link
Owner

@TheJoeFin TheJoeFin Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect editor config style and use explicit types

Copy link
Contributor Author

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to explicit type IEnumerable<ButtonInfo> in commit 481aad0.

Text-Grab/Utilities/PostGrabActionManager.cs Outdated
if (!string.IsNullOrWhiteSpace(line))
finalString += line.Trim() + Environment.NewLine;
result = finalString;
var trimmedLines = stringSplit
Copy link
Owner

@TheJoeFin TheJoeFin Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use explicit types

Copy link
Contributor Author

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to explicit type string[] in commit 481aad0.

Copilot AI requested a review from TheJoeFin January 11, 2026 20:57
@TheJoeFin TheJoeFin marked this pull request as ready for review January 11, 2026 21:02
@TheJoeFin TheJoeFin merged commit 6348864 into customize-FSG-post-grab Jan 11, 2026
@TheJoeFin TheJoeFin deleted the copilot/sub-pr-606 branch January 11, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheJoeFin TheJoeFin TheJoeFin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TheJoeFin TheJoeFin

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheJoeFin