HistoryService: path traversal sanitization and exception resilience#636
Merged
TheJoeFin merged 2 commits intobetter-memfrom Mar 10, 2026
Merged
HistoryService: path traversal sanitization and exception resilience#636TheJoeFin merged 2 commits intobetter-memfrom
TheJoeFin merged 2 commits intobetter-memfrom
Conversation
Open
…vice Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve memory usage and persistence for data
HistoryService: path traversal sanitization and exception resilience
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HistoryServiceused persistedWordBorderInfoFileNamevalues directly inPath.Combinewithout sanitization, enabling path traversal. File delete and deserialization paths also had no error handling, meaning a corrupt/locked file could crash history operations.Changes
GetWordBorderInfosAsync: sanitizeWordBorderInfoFileNameviaPath.GetFileName()and reject non-.jsonextensions before path combination; wrap sidecar file IO + deserialization inIOException/JsonExceptionhandlers with fallthrough to inline JSON; wrap inline JSON deserialization inJsonExceptionhandler returning[]DeleteHistoryFile: wrapFile.DeleteinIOException/UnauthorizedAccessException— locked files log and continue instead of throwingDeleteUnusedWordBorderFiles: same per-iteration exception handling so one inaccessible sidecar doesn't abort cleanup of the rest💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.