Conversation
|
Note, there is more to do: #41 |
I've added the extensions mentioned in this issue. Question: is there a mechanism to specify the extensions based on the used clang-format version? Or should I add them unconditional like I did? |
``` Configuration file(s) do(es) not support Json ``` with clang-formt 18.0.0
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Thanks for adding the new extensions! Seems there is still an issue with the CI being outdated. I'll investigate and update the PR.
| 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'inc', 'inl', # C++ | ||
| 'cu', # CUDA | ||
| 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'inc', # C++ | ||
| 'ccm', 'cppm', 'cxxm', 'c++m', # C++ Modules |
There was a problem hiding this comment.
Any reason to remove the inl extension?
There was a problem hiding this comment.
Note: asio use ipp, boost, and ACE use inl
There was a problem hiding this comment.
I've re-added the inl file ending and additionally added ipp.
|
CI is now fixed, but there's a merge conflict, and I think we should keep the |
|
Thanks for the update! I'm not sure why the CI is not running (and there seems to be no option for me to start it). Can you check if GitHub Actions is enabled on your branch? |
|
Sorry, I found the issue now and could start the workflow manually! (I was using the "new merge experience" which seems to be missing the button) |
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Thanks for adding the extension!
|
For some reason, at one point, the actual ".hip" extension was lost again in this PR :/ |
3 participants
Add the .hip extensions for the HIP language dialect (similar to .cu in CUDA).