Auctionator Midnight Professions Frame Fixes#1786
Open
ynazar1 wants to merge 3 commits intoTheMouseNest:masterfrom
Open
Auctionator Midnight Professions Frame Fixes#1786ynazar1 wants to merge 3 commits intoTheMouseNest:masterfrom
ynazar1 wants to merge 3 commits intoTheMouseNest:masterfrom
Conversation
Author
|
Edit update this to be only conformant with crafting UI. Split off enchanting into its own thing |
- Tooltip: use GetRecipeOutputLink when Crafting page visible for correct auction price on quality/ilvl items (armor, weapons) - Profit: shared GetRecipeOutputLink with qualityItemIDs (13/14 -> q-12 for Midnight) - Profit: hide for BoP crafted results - Deferred updates on Init/AllocationsModified/UseBestQualityModified/statsChangedHandler so profit line shows on first click and when toggling concentration Fixes: Crafting UI tooltip now shows correct AH price based on item level or quality level. Profit line correct for both single-quality and multi-quality recipes. Profit line hidden when crafted result is bind-on-pickup. Resolves race condition so profit line displays reliably on first recipe selection and when switching concentration/guaranteed quality. Made-with: Cursor
ynazar1
force-pushed
the
midnight-crafting-ui-fixes
branch
from
b7cf914 to
32244ea
Compare
Made-with: Cursor
Made-with: Cursor
Author
|
Testing: Tested on enchanting/tailoring/inscription. No issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
GetRecipeOutputLinkwhen the Crafting page is visible for correct auction price on quality/ilvl items (armor, weapons).GetRecipeOutputLinkwithqualityItemIDs(Midnight: quality 13/14 mapped to index viaq - 12).Init,AllocationsModified,UseBestQualityModified, andstatsChangedHandlerto avoid race conditions and ensure the profit line updates correctly.