Feature: Shopping, add shortcut to skip buy confirmation dialogs#1787
Open
ynazar1 wants to merge 2 commits intoTheMouseNest:masterfrom
Open
Feature: Shopping, add shortcut to skip buy confirmation dialogs#1787ynazar1 wants to merge 2 commits intoTheMouseNest:masterfrom
ynazar1 wants to merge 2 commits intoTheMouseNest:masterfrom
Conversation
ynazar1
changed the title
ynazar1
force-pushed
the
shortcut-to-skip-buy-comfirmation
branch
from
92d64f3 to
435520d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add a configurable shortcut (e.g. Alt+Right Click) in the Shopping tab to complete purchases immediately without confirmation dialogs. Default is Disabled (NONE). Tooltip warns "Use with caution" in red. When disabled or non-conformant (ie: click vs
chosen Alt+click) behaves same as default, showing confirmations.Files Changed
Config
Source_ModernAH/Config/Main.lua– AddedSHOPPING_SKIP_BUY_CONFIRMATIONoption and defaultSource_ModernAH/Config/Frames/ShoppingAlt.xml– Added SkipBuyConfirmationShortcut dropdownSource_ModernAH/Config/Mixins/ShoppingAlt.lua– Wired ShowSettings and Save for the shortcutComponents
Source/Components/Frames/DropDown.xml– Added tooltip mixin and OnEnter/OnLeave for shortcut dropdownsCommodity Buying
Source_ModernAH/Tabs/Buying/Commodity/Frames/Main.xml– Pass mouse button to BuyClickedSource_ModernAH/Tabs/Buying/Commodity/Mixins/Main.lua– UpdatedBuyClickedandCheckPurchaseItem Buying
Source_ModernAH/Tabs/ResultsListing/Mixins/BuyItemRow.lua– Check shortcut and pass skipConfirmation inOnClickSource_ModernAH/Tabs/Buying/Item/Mixins/Dialog.lua– UpdatedReceiveEventto accept skipConfirmationLocales
Locales/enUS.lua– Added strings for the new option and tooltip