Show / hide the search button consistently even fresh after login#1798
Open
RedAces wants to merge 1 commit intoTheMouseNest:masterfrom
Open
Show / hide the search button consistently even fresh after login#1798RedAces wants to merge 1 commit intoTheMouseNest:masterfrom
RedAces wants to merge 1 commit intoTheMouseNest:masterfrom
Conversation
even fresh after login
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
the search button (for tracked profession recipes) does not show up for me if I track a new recipe.
It DOES show up if I have a recipe tracked and reload!
Debugging this problem I found that this button should ONLY show up if
Auctionator.Config.Options.CRAFTING_INFO_SHOWis set. Some time ago I deactivated this.This PR fixes the problem that this button shows up on reload (or login) if the config is not set. This makes it consistent to tracking a recipe later!
Additonally I think there are 2 more problems:
-- Always show the search buttons
-- Add a new config for this search button with a clear explanation
-- Change the existing description of the checkbox to include the search button.
What do you think for the first problem? I could provide the code if you decide which option you like.