Open
Conversation
- added spec name/arena ID widgets - added centered horizontal growth for auras - changed creature text widget to also have the ability to show arena ID/spec name instead inside of arena
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be cool if you reviewed these and implemented them as these features would be well welcomed by arena players. I tried to not write shitty code but I'm new to LUA so probably got some things wrong.
(also I haven't checked if enabling centered horizontal growth in code for auras broke it but scaling of CC auras inside arena is hit or miss - sometimes they scale properly to the user defined size, sometimes they stay the default size - I found it weird you haven't enabled centered growth yet even though the code was practically already written, maybe because of this reason?)