Added Enemy not in Combat functionality#119
Open
TheIceBadger wants to merge 5 commits intoTheMouseNest:mainfrom
Open
Added Enemy not in Combat functionality#119TheIceBadger wants to merge 5 commits intoTheMouseNest:mainfrom
TheIceBadger wants to merge 5 commits intoTheMouseNest:mainfrom
Conversation
Adds a new dropdown to the "Style Select" for "Enemy not in combat" This allows users to design a style for enemies who is not in combat with the player. Combat check should be if player attacks enemy, enemy targets /attacks player, should also include party. Unsure if this is proper implementation of the feature, or if it has any major performance impact, however it seems to work well in limited testing.
Was using wrong method of getting value to see if party members are being attacked, this should fix this issue.
ok, I messed up, lots of this stuff was not needed and I think after some more thorough testing, this is no longer causing any lua errors, Im not familiar enough with the new restrictions and what values are secret yet...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new drop-down to the "Style Select" for "Enemy not in combat" This allows users to design a style for enemies who is not in combat with the player.
In response to #86 and request from friend.
Combat check should be if player attacks enemy, enemy targets /attacks player, should also include party.
Unsure if this is proper implementation of the feature, or if it has any major performance impact, however it seems to work well in limited testing.
If this is not the correct way of doing this, but the code could be of help to implement it properly, please feel free to use any parts that can help!