feat: add player title with UnitPVPName for CreatureText#208
Open
le-u-f wants to merge 8 commits intoTheMouseNest:mainfrom
Open
feat: add player title with UnitPVPName for CreatureText#208le-u-f wants to merge 8 commits intoTheMouseNest:mainfrom
le-u-f wants to merge 8 commits intoTheMouseNest:mainfrom
Conversation
Author
|
I don't know how locales work, so here's the list if you want to add them -- frFR
L["SHOW_PLAYERS_TITLE"] = "Afficher le titre des joueurs"
-- deDE
L["SHOW_PLAYERS_TITLE"] = "Spielertitel anzeigen"
-- ruRU
L["SHOW_PLAYERS_TITLE"] = "Показать название игрока"
-- ptBR
L["SHOW_PLAYERS_TITLE"] = "Mostrar título dos jogadores"
-- esES
L["SHOW_PLAYERS_TITLE"] = "Mostrar el título del jugador"
-- esMX
L["SHOW_PLAYERS_TITLE"] = "Mostrar el título del jugador"
-- zhTW
L["SHOW_PLAYERS_TITLE"] = "顯示玩家標題"
-- zhCN
L["SHOW_PLAYERS_TITLE"] = "显示玩家标题"
-- koKR
L["SHOW_PLAYERS_TITLE"] = "플레이어 타이틀 표시"
-- itIT
L["SHOW_PLAYERS_TITLE"] = "Mostra il titolo dei giocatori" |
Author
|
Hi @plusmouse, could you take a look at this PR please? I'm using it and it works perfectly, but I have to re-edit the code locally every time I download a Platynator update, which isn't very convenient 😝 Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83