Fix OTP/passkey login flow handling #450
Open
+117
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNetsky
reviewed
Jan 15, 2026
|
Hey there, thanks for helping me with this issue, i tested your PR in my case #429, i got loop forever. For my case, just need to click Use your password then paste the password, just like in the image. 
And this is your PR result for my case below. 
|
Contributor
Author
|
@meichengg Oh interesting, it didn't do this for me. I will investigate further. Did you wait and give it time to navigate that page? |
I just let the tool do its job, i didn't touch anything. |
Owner
|
Can either @Titaniumtown implement the fixes from the PR from @meichengg or vice versa so one of the PR's can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues cropped up with the login flow resulting from 3.1.0.
Specifically I was hitting failures with the passkey creation, which fails. I don't know why this stuff was being activated in the first place, but I added code that will just skip it.
I also was hitting issues with the bot getting lost on the login flow and ending up on the OTP page. I am not 100% about this code though.
Closes: #449 & #429