Skip to content

Fix: Remove duplicate header logo anchor element #5204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsmchen wants to merge 1 commit into from
+1 −4
Closed

Fix: Remove duplicate header logo anchor element #5204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/logo_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<%= link_to redirect_to_path, 'aria-label': 'Return back home' do %>
<%= image_tag 'icons/odin-icon.svg', alt: 'Odin Logo', class: 'lg:hidden h-12 w-auto' %>
<%= inline_svg_tag 'logo.svg', class: "#{classes} text-gray-800 dark:text-gray-300", aria: true, title: 'Odin Logo' %>
<% end %>
4 changes: 0 additions & 4 deletions app/views/shared/_navbar.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<div class="flex justify-between">
<div class="flex">
<div class="shrink-0 flex items-center">
<%= link_to root_path, class: 'logo', 'aria-label': 'Return back home' do %>
<%= image_tag 'icons/odin-icon.svg', alt: 'Odin Logo', class: 'block lg:hidden h-12 w-auto' %>
<% end %>

<%= render LogoComponent.new(classes: 'hidden lg:block h-12 w-auto') %>
</div>

Expand Down