Skip to content

Fix libraries feeds date string timezone errors (PP-3938)#905

Merged
tdilauro merged 1 commit intomainfrom
bugfix/libraries-feed-tz-errors
Mar 24, 2026
Merged

Fix libraries feeds date string timezone errors (PP-3938)#905
tdilauro merged 1 commit intomainfrom
bugfix/libraries-feed-tz-errors

Conversation

@tdilauro
Copy link
Copy Markdown
Collaborator

Description

  • Corrects a long-standing typo/error in the date format string used to format the dates in the libraries (full and crawlable) OPDS feeds.

Motivation and Context

On #883, we made our dates timezone aware. The extra "Z%z" at the end of the incorrect format string caused dates to end with the letter "Z" for Zulu/UTC and the timezone +/- offset. This wasn't a problem with naive dates because there was no timezone; however, when we activated timezones, we ended up with dates that ended in "Z+0000". Those dates were not valid ISO 8601.

[Jira PP-3938]

How Has This Been Tested?

  • Manually verified that the dates look correct.
  • Added new tests to catch any changes to the format string.
  • All tests pass locally.
  • CI tests and other checks pass.

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro added the bug Something isn't working label Mar 23, 2026
@tdilauro tdilauro requested a review from a team March 23, 2026 22:24
Copy link
Copy Markdown
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@tdilauro tdilauro merged commit ff4c67e into main Mar 24, 2026
10 checks passed
@tdilauro tdilauro deleted the bugfix/libraries-feed-tz-errors branch March 24, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants