Fix some edge cases in dex2oat.c#19
Conversation
fatalcoder524
commented
Jan 23, 2026
fatalcoder524
commented
- Treat the newly installed app similarly to an app in the denylist.
- Do not continue if liboat_hook is not found.
- Add retry support for the write_string operation.
- Treat the newly installed app similarly to an app in the denylist. - Do not continue if liboat_hook is not found. - Add retry support for the write_string operation.
|
I don't see to: If the user's system works on a blacklist logic, it is only reasonable it would also follow that |
Nope. If KSU is set to manual umount and not global default umount, it doesn't work. So this will prevent that for first dex2oat and gives time for user the configure umount list. Also no need of reoptimize after setting umount. People forget they have reoptimize and also many don't know what it even does. This should provide temporary protection for a small period of time! |
| if (ret <= 0) { | ||
| PLOGE("write_string data failed"); | ||
| return; // or abort, since protocol is broken | ||
| } |
| if (strncmp(argv[i], prefix, prefix_len) != 0) continue; | ||
| if (strncmp(argv[i], compilation_reason_prefix, compilation_reason_prefix_len) == 0) { | ||
| const char* reason = argv[i] + compilation_reason_prefix_len; | ||
| if (strcmp(reason, "install") == 0) { |
There was a problem hiding this comment.
use early-continue, avoid entering scopes
2 participants
