Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 3, 2025

This PR contains the following updates:

Package Type Update Change
linuxserver/jellyfin (source) patch 10.11.1 -> 10.11.2
nvidia-device-plugin HelmChart minor 0.17.4 -> 0.18.0

Release Notes

NVIDIA/k8s-device-plugin (nvidia-device-plugin)

v0.18.0

Compare Source

  • Rename getHealthCheckXids and clarify documentation
  • Add support for explicitly enabling XIDs in health checks
  • Deduplicate requested device IDs
  • Check for nil before reading boolean config values
  • Make gated modes (GDS, MOFED, GDRCOPY) optional in CDI
  • Add support for setting gdrcopyEnabled
  • Ignore errors getting device memory using NVML
  • Ensure that directory volumes have Directory type
  • Switch to plain golang image for builds
  • Remove unneeded intermediate container
  • Update CI definitions
  • Switch to distroless golang image
  • Update README.md with RuntimeClass
  • Pass a single context throughout the device-plugin method call stack (#​1284)
  • Remove internal logger in favour of klog (#​1277)
  • Remove FAIL_ON_INIT_ERROR from static examples
  • Detect blackwell architecture
  • Updated .release:staging to stage device-plugin images in nvstaging
  • Use MiB instead of MB for gpu-memory
  • Ignore XID error 109
  • Update README.md adjust set docker runtime default
  • Remove nvidia.com/gpu.imex-domain label
  • Fix containerd runc config error when creating a kind cluster
  • Use stable nividia-container-toolkit repo when creating a kind cluster
  • Switch to context package in go stdlib
  • Raise a warning instead of an error if GPU mode labeler fails
  • Add ada-lovelace architecture label for compute capability 8.9
  • Ensure FAIL_ON_INIT_ERROR boolean env is quoted
  • Honor fail-on-init-error when no resources are found
  • Enable hostPID in the mps-control-daemon pod (#​1045)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot merged commit 15d4d59 into main Nov 3, 2025
@renovate renovate bot deleted the renovate/all-minor-patch branch November 3, 2025 05:05
@claude
Copy link

claude bot commented Nov 3, 2025

Pull Request Review - PR #177: Update All non-major dependencies

Summary

This PR updates two dependencies:

  • Jellyfin: 10.11.1 -> 10.11.2 (patch)
  • nvidia-device-plugin: 0.17.4 -> 0.18.0 (minor)

Code Quality & Best Practices ✅

  • Clean changes: Only version bumps, no code modifications
  • Proper Kubernetes manifests: Both files follow standard Kubernetes YAML structure
  • Semantic versioning: Updates follow proper semver conventions (patch for Jellyfin, minor for nvidia-device-plugin)

Potential Issues & Considerations

nvidia-device-plugin (0.17.4 -> 0.18.0) ⚠️

This is a minor version update with significant changes. Key considerations:

  1. Breaking changes in logging: The update removes internal logger in favor of klog (#1277). If you have any log parsing or monitoring, verify compatibility.

  2. Removed environment variable: FAIL_ON_INIT_ERROR behavior changed. The plugin now honors this flag when no resources are found, which could affect startup behavior.

  3. Architecture detection updates: Added Blackwell architecture detection and Ada-Lovelace labels (compute capability 8.9). Ensure this aligns with your GPU hardware.

  4. Health check changes: XIDs handling was modified - XID error 109 is now ignored. Review if you rely on specific XID error reporting.

  5. hostPID enabled: MPS control daemon now runs with hostPID: true (#1045). This is a security consideration - it grants the pod access to host PIDs.

Jellyfin (10.11.1 -> 10.11.2) ✅

Patch update - should be safe. However:

  • Monitor transcoding performance post-upgrade (GPU-related given your nvidia.com/gpu: "1" resource limit in deployment.yaml:31)
  • Verify hardware acceleration still works correctly with the updated container

Security Concerns 🔒

  1. Trusted sources: Both images are from reputable sources (linuxserver.io and NVIDIA official)
  2. Version pinning: Good practice - versions are pinned rather than using latest tags
  3. GPU access: The Jellyfin deployment has GPU access (nvidia.com/gpu: "1") - ensure this is intentional and necessary
  4. hostPath volume: deployment.yaml:47-48 uses hostPath /Storage/Media - ensure proper path permissions and security context

Performance Considerations 📊

  1. GPU time-slicing: Your nvidia-device-plugin config has time-slicing enabled with 2 replicas (values.yaml:12). The 0.18.0 update includes performance improvements for device ID deduplication which should benefit this configuration.

  2. Memory handling: The new version ignores errors getting device memory using NVML - this could mask GPU memory issues but prevents crashes on partial failures.

Test Coverage 🧪

Recommendation: This is a dependency update PR with no test changes, which is expected. However, consider:

  • Integration testing: Deploy to a staging environment first if available
  • GPU functionality: Verify Jellyfin transcoding works post-update
  • Device plugin: Ensure GPU resources are properly advertised to Kubernetes
  • Monitoring: Check for any new error patterns in logs after deployment

Recommendations

  1. Approve and merge - Changes are minimal and well-scoped
  2. ⚠️ Post-deployment verification:
    • Verify GPU device detection: kubectl describe nodes | grep nvidia.com/gpu
    • Check nvidia-device-plugin logs for errors
    • Test Jellyfin hardware transcoding functionality
  3. 📝 Consider documenting: The time-slicing configuration (2 replicas) should be documented if not already

Conclusion

LGTM - This is a clean dependency update PR from Renovate. The changes are minimal (2 lines) and follow best practices. The nvidia-device-plugin minor version bump includes useful improvements and bug fixes. No code quality, security, or performance concerns that would block merging.

The PR is suitable for automerge as configured, but monitor the deployment afterward given the minor version bump on the nvidia plugin.


Review generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant