Fixing Kerberos Name Type in AS requests #123
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR on fortra/impacket: fortra#1495
Hello there,
It was discovered that Impacket uses the KRB_NT_PRINCIPAL name type in AS-REQs instead of the KRB_NT_SRV_INST name type which was required by the specification (RFC 4120).
In some cases this can lead to a KRB_AP_ERR_BAD_INTEGRITY error when a received TGT is used. This may be a behavior of a fully-updated Windows machine but I don't know perhaps it's for some obscure configurations only.