Feature phase_number configuration option

[oldboys92]

Adds phase_number configuration and update power data handling for mono-phase and tri-phase

[TheRealMoeder]

All good, maybe you could add a little sentence to the documentation what this configuration option does?

[oldboys92]

I've also realized, that this option is not considered for JSON path parsing routines. Feeling a little bit unsure to touch that code base :-) What do you think?

[TheRealMoeder]

what do you mean by that?

[oldboys92]

I mean the phase number is not used in the HTTP and MQTT JSON path parsing functions, only for the adapted functions setPowerData and setEnergyData.

[TheRealMoeder]

I would clarify in the documentation, that phase_number is the energy2shelly output configuration, as in how the emulator presents the input data in the Shelly emulation output. This makes it clearer, that TRIPHASE in Jsonpath settings is for input configuration and phase_number represents how whatever input data is presented to the Shelly output.

To be consistent, we should extend the triphase setPowerData, so that it sums up TRIPHASE input data and outputs on a single phase for cases where phase_power is 1. What do you think?

BTW, this will also be the correct solution for #89

[TheRealMoeder]

Great, thanks for the changes. With this implemented we could also add EM1.GetStatus to the rpc handler when in monophase mode, right?

[oldboys92]

Great, thanks for the changes. With this implemented we could also add EM1.GetStatus to the rpc handler when in monophase mode, right?

Not sure. I need to double check it. Can you open an issue and link it, so we can look into it?

[oldboys92]

@TheRealMoeder if I understand correctly, the EM1 component is for ShellyProEM, do we want to support this?

[TheRealMoeder]

I had a very lengthy discussion in #28 if you have time to read it up....but I think other things have higher priority

[oldboys92]

Long thread #28. I agree, if somebody really needs that, he can do a PR quite easy now.