-
-
Notifications
You must be signed in to change notification settings - Fork 632
Add Remove All Whitespace in JavaScript #4268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Remove All Whitespace in JavaScript #4268
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
rzuckerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why replaceAll isn't working is that we are using a very old version of node. I think if you edit testinfo.yml and change the version from 11-alpine to 20-alpine you may have better results. Also /\s/g is the correct regex to use
|
It seems like upgrading the container broke some other programs, and I'm not sure if |
|
@Kaamkiya , If upgrading to node 20 is breaking existing tests, just go back to |
|
Okay, I've downgraded the node image version and updated my code to match that version. |
rzuckerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Kaamkiya . Thanks for trying out node 20. Sorry that it didn't work out.
I Am Adding a New Code Snippet in an Existing Language
Add {PROJECT} in {LANGUAGE}format