Skip to content

Conversation

@AAshGray
Copy link
Contributor

@AAshGray AAshGray commented Feb 14, 2025

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AAshGray! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

Copy link
Member

@Kaamkiya Kaamkiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to validate numbers by checking that there are no letters in the input. But what if there are other characters, like $ or ;?

Please account for this, and I'll look at it again.

Thanks :)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@Kaamkiya Kaamkiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging now.

@Kaamkiya Kaamkiya merged commit 051e521 into TheRenegadeCoder:main Feb 15, 2025
7 checks passed
@rzuckerm rzuckerm added enhancement Any code that improves the repo josephus problem See: https://sampleprograms.io/projects/josephus-problem/ labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo josephus problem See: https://sampleprograms.io/projects/josephus-problem/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Josephus Problem in Ruby

3 participants