-
-
Notifications
You must be signed in to change notification settings - Fork 632
Add new project: base64 encode decode #4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I'll hold off merging this until the article is ready. I'm not sure what would happen with the README automation if there is project here that doesn't have a corresponding article
jrg94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
| - " *" | ||
| transformations: | ||
| - "splitlines" | ||
| base64_encode_decode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so thankful we moved to a config file format for the tests. I will say: I deleted my twitter account for good, and part of the reason was that tech bros constantly post rage bait. I recently saw multiple people claiming YAML is a terrible config file format, and I just don't really get it. There really was one guy going on this huge crusade about it not being typesafe, and that a turing-complete language is better for configurations. In my mind, I was thinking: wasn't setup.py one of the most painful files to setup for a project? I'll stick to my simple YAML, JSON, TOML files.
I will say the folks I've seen complaining about YAML use it in K8s, and I guess that can be annoying. I also find the GitHub Actions use of YAML to be a bit finicky. Anyway, thanks for reading my late night thoughts 😆
| from typing import NoReturn | ||
|
|
||
|
|
||
| def usage() -> NoReturn: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never actually seen this before. Is this because the function exits no matter what, so it has no chance to return None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, NoReturn means what it says: the function never returns. The program just exits.
|
|
||
| def is_prime(x): | ||
| if (x % 2 == 0 and x is not 2) or (x == 1): | ||
| if (x % 2 == 0 and x != 2) or (x == 1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
| container: | ||
| image: "python" | ||
| tag: "3.7-alpine" | ||
| tag: "3.12-alpine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a wonderfully good jump!
I Am Adding a New Project
This was discussed in the Discord server.
I am willing to make changes if they are needed :)