Skip to content

Conversation

@jrg94
Copy link
Member

@jrg94 jrg94 commented Mar 10, 2025

I updated the Poetry file format to 2.1.1. I was able to verify this is the correct format using the poetry check command. Currently, however, poetry update is not working, and it's failing on the markupsafe dependency when the minimum python version is 3.8. With 3.8 set to 3.9, poetry update hangs on black and pydantic.

@rzuckerm
Copy link
Collaborator

I got nowhere with the pydantic maintainers. They could not reproduce the issue. They are suggesting that this is a poetry bug. In the meantime, I would suggest removing Swift from the CodeQL workflow and scripts/get_codeql_languages.py

@jrg94 jrg94 marked this pull request as ready for review March 13, 2025 18:10
@jrg94 jrg94 requested a review from rzuckerm March 13, 2025 18:10
@jrg94 jrg94 added the dependencies Pull requests that update a dependency file label Mar 13, 2025
@jrg94 jrg94 added this to Automation Mar 13, 2025
@github-project-automation github-project-automation bot moved this to In progress in Automation Mar 13, 2025
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jrg94 !

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, was a little to quick on the review. Please also remove Swift from scripts/build_codeql_languages.py

@jrg94
Copy link
Member Author

jrg94 commented Mar 13, 2025

Still having no luck with installing pydantic or black on my windows machine, but I found this thread which documents a similar issue: python-poetry/poetry#7881. I'm going to keep toying around, but as long as the repo works I'm happy.

@jrg94
Copy link
Member Author

jrg94 commented Mar 13, 2025

Just kidding! The issue was the artifacts folder. I cannot believe it. Once I deleted that and called poetry lock then poetry install, the issue went completely away.

As usual, it was a me issue.

I wasn't sure if I should update the Poetry requirement as well
@rzuckerm rzuckerm merged commit 6819df5 into main Mar 14, 2025
16 checks passed
@rzuckerm rzuckerm deleted the poetry-2.0-migration branch March 14, 2025 12:11
@github-project-automation github-project-automation bot moved this from In progress to Done in Automation Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants